On Fri, Jan 13, 2023 at 03:56:59PM +0100, Konrad Dybcio wrote: > > > On 13.01.2023 05:11, Bjorn Andersson wrote: > > This implements the base PMIC GLINK driver, a power_supply driver and a > > driver for the USB Type-C altmode protocol. This has been tested and > > shown to provide battery information, USB Type-C switch and mux requests > > and DisplayPort notifications on SC8180X, SC8280XP and SM8350. > > > For the series: > > Tested-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> # SM8350 PDX215 > > Thanks a lot for working on this! > Thank you for testing it :) > One thing, /sys/class/power_supply/qcom-battmgr-usb/input_current_limit > is stuck at zero and so is the current_now as a result (the voltage > readout is 5V + some noise, so that looks good), but I don't see any > SET paths for it in the driver, so I suppose that's what the firmware > default is? > I have not experimented with adjusting any configuration in this initial set, but there are a few knobs that could/should be introduced on top of this. That said, I believe input_current_limit should somehow come from the USB stack, rather than user space? Regards, Bjorn
