On 1/15/23 6:38 AM, Krzysztof Kozlowski wrote:
On 13/01/2023 19:08, Tanmay Shah wrote:
On 1/12/23 11:52 PM, Krzysztof Kozlowski wrote:
On 13/01/2023 08:30, Tanmay Shah wrote:
This patch introduces bindings for TCM memory address space on AMD-xilinx
platforms. As of now TCM addresses are hardcoded in xilinx remoteproc
driver. This bindings will help in defining TCM in device-tree and
make it's access platform agnostic and data-driven from the driver.
Subject: drop second/last, redundant "bindings". The "dt-bindings"
prefix is already stating that these are bindings.
Ack.
Where is driver or DTS? Are you now adding a dead binding without users?
TCM is used by drivers/remoteproc/xlnx_r5_remoteproc.c driver. Howerver,
we have hardcode addresses in TCM as bindings are not available yet.
I don't see usage of these compatibles there. You also did not supply
DTS here. Please provide users of bindings within the same patchset.
ACK. I will supply dts as well.
However, Is it ok if I convert this patch to RFC patch, and once
bindings are fixed I will send actual patch with driver support.
If bindings design is not correct then I might have to change
corresponding driver design lot.
Best regards,
Krzysztof
