On pią, 2014-11-07 at 14:00 +0100, Javier Martinez Canillas wrote: > Hello Mark, > > This is the fifth version of the series that adds regulator initial > and suspend operating modes support. It relies on the existing work > that added suspend states bindings. The opmodes are parsed by the > regulator core and drivers should only define a translation function > to map between hardware specific to standard modes. > > The series adds a "regulator-initial-mode" property to configure at > startup, the operating mode for the regulators that support changing > its mode during normal operation and a "regulator-mode" property for > the regulators that supports changing its operating mode when the > system enters in a suspend state. These properties were originally > part of Chanwoo Choi's regulator suspend state series [0] but were > removed since there wasn't a way to define the operating modes in a > generic way. > > The generic regulator DT binding doc explains that each device has > to document what their valid operating modes are and drivers must > add a translation function so the core knows how to map the opmodes. > > Older versions of this series were meant to add initial and suspend > modes for the max77802 regulator driver but the feedback was that > this should had been done in a generic way. The latest version was > "[PATCH v4 00/14] Add Maxim 77802 PMIC support" [1] but that series > mixed core changes, bugfixes and new driver features. > > This series instead contains only the patches that add the support > to the regulator core and drivers are only modified when a function > signature is changed to maintain git bisect-ability. > > If the patches are merged, following series will change the drivers > using of_regulator_match() to pass the regulator description in the > match table and another series will add the new opmode feature in > the max77802 regulator driver. > > The series is composed of the following patches: > > Javier Martinez Canillas (5): > regulator: Document binding for initial and suspend modes > regulator: Add function to map modes to struct regulator_desc > regulator: of: Add regulator desc param to > of_get_regulator_init_data() > regulator: of: Pass the regulator description in the match table > regulator: of: Add support for parsing initial and suspend modes I see my previous thoughts were addressed. I had few minor questions about patch 3/5 but still whole patchset looks fine to me. Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
