Hi Clément, Thanks for your patch! On Mon, Jan 16, 2023 at 11:37 AM Clément Léger <clement.leger@xxxxxxxxxxx> wrote: > Add "renesas,rzn1-gmac" binding documention which is compatible which documentation > "snps,dwmac" compatible driver but uses a custom PCS to communicate > with the phy. > > Signed-off-by: Clément Léger <clement.leger@xxxxxxxxxxx> > --- > .../bindings/net/renesas,rzn1-gmac.yaml | 71 +++++++++++++++++++ > 1 file changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > > diff --git a/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > new file mode 100644 > index 000000000000..effb9a312832 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/renesas,rzn1-gmac.yaml > @@ -0,0 +1,71 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/renesas,rzn1-gmac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas GMAC1 Device Tree Bindings > + > +maintainers: > + - Clément Léger <clement.leger@xxxxxxxxxxx> > + > +select: > + properties: > + compatible: > + contains: > + enum: > + - renesas,r9a06g032-gmac > + - renesas,rzn1-gmac > + required: > + - compatible > + > +allOf: > + - $ref: "snps,dwmac.yaml#" > + > +properties: > + compatible: > + additionalItems: true > + maxItems: 3 > + items: > + - enum: > + - renesas,r9a06g032-gmac > + - renesas,rzn1-gmac > + contains: > + enum: > + - snps,dwmac Why not just items: - enum: - renesas,r9a06g032-gmac - renesas,rzn1-gmac - snps,dwmac ? > +examples: > + - | > + #include <dt-bindings/clock/r9a06g032-sysctrl.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + ethernet@44000000 { > + compatible = "renesas,rzn1-gmac"; Documentation/devicetree/bindings/net/renesas,rzn1-gmac.example.dtb: ethernet@44000000: compatible: ['renesas,rzn1-gmac'] does not contain items matching the given schema > + reg = <0x44000000 0x2000>; > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; > + clock-names = "stmmaceth"; > + clocks = <&sysctrl R9A06G032_HCLK_GMAC0>; > + snps,multicast-filter-bins = <256>; > + snps,perfect-filter-entries = <128>; > + tx-fifo-depth = <2048>; > + rx-fifo-depth = <4096>; > + pcs-handle = <&mii_conv1>; > + phy-mode = "mii"; > + }; > + > +... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
