On 16/01/2023 09:01, Yong Wu (吴勇) wrote: > On Fri, 2023-01-13 at 09:25 +0100, Krzysztof Kozlowski wrote: >> On 13/01/2023 07:01, Yong Wu wrote: >>> MediaTek iommu has already controlled the masters' iova ranges by >>> the >>> master's larb/port id. then the dma-ranges property is unnecessary >>> for > >> Sentences in English always start with a capital letter, however also >> they do not start with "Then". Make it a proper a proper sentence. > > Sorry for the syntax issues. I think it is "," before "then". > >>> the master's node. the master is vcodec here. >> >> Unnecessary or invalid? > > For mt8195, It is unnecessary. For the other SoC which doesn't use > parent/child node, the property is invalid, however, there is no vcodec > node have this property in this case in the current upstream dts nodes. > >> Don't you depend now on some feature of driver >> added for example recently? > > No. It doesn't depend on any the other patches. Just depend > on the code changing in this patchset. I just put the dt-binding > at the beginning of this series. So this is an ABI change where you expect no upstream users to be affected? Why you do not clarify it in commit msg? > >>> >>> Cc: Tiffany Lin <tiffany.lin@xxxxxxxxxxxx> >>> Cc: Andrew-CT Chen <andrew-ct.chen@xxxxxxxxxxxx> >>> Cc: Yunfei Dong <yunfei.dong@xxxxxxxxxxxx> >>> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> >>> Cc: Rob Herring <robh+dt@xxxxxxxxxx> >>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx> >> >> There is little point in storing output of get_maintainers.pl forever >> in >> the git log. If you need it for some reason, please keep it after - >> --. > > I did get the list from get_maintainers.pl. Sorry that I didn't > differentiate. Getting the list from get_maintainers.pl is correct but storing it forever in git log is really unnecessary. It's not useful. It's just automated output, reproducible at any given time. > Best regards, Krzysztof
