On Fri, Jan 13, 2023 at 02:23:51PM -0600, Rob Herring wrote: > On Thu, Jan 12, 2023 at 06:22:25PM +0200, Andy Shevchenko wrote: > > On Thu, Jan 12, 2023 at 04:51:40PM +0200, Andy Shevchenko wrote: > > > GPIO library for OF is the only user for enum of_gpio_flags. > > > Move it there. ... > > > +/* > > > + * This is Linux-specific flags. By default controllers' and Linux' mapping > > > + * match, but GPIO controllers are free to translate their own flags to > > > + * Linux-specific in their .xlate callback. Though, 1:1 mapping is recommended. > > > + */ > > > > Now that I re-read the comment, I think this can be postponed until we get a > > consensus that no new driver is ever should do non 1:1 mapping. > > > > If that consensus achieved, we may drop this enum altogether and replace it > > with the generic flags.. > > We don't keep things with no users. We can move this back if there ever > is a user. Yes! But my point to go even deeper and replace this 1:1 mapped bits by the generic ones. -- With Best Regards, Andy Shevchenko
