On Wed, 11 Jan 2023 at 02:06, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > + * Limitations: > > + * - The writes to cycle registers are shadowed until a write to > > + * the control register. > > + * - If both OFF_CYCLES and ON_CYCLES are set to 0, the output > > + * is a constant off signal. > > How does the PWM behave with *APPLE_PWM_CTRLAPPLE_PWM_CTRL = 0? > (typically: drives constant low) > APPLE_PWM_CTRL = 0 implies that the APPLE_CTRL_ENABLE bit is set low, which turns off the pwm signal (constant low). I do not think that it is necessary to explicitly specify that case in the comments. > Can you please rename such that the (maybe new) name for APPLE_PWM_CTRL > is a prefix for the (maybe new) APPLE_CTRL_ENABLE and the other register > bit definitions? To make sure, you want the register named APPLE_PWM_CTRL, and the bits named APPLE_PWM_CTRL_ENABLE, APPLE_PWM_CTRL_MODE and so on?
