On 1/11/2023 3:06 PM, Krzysztof Kozlowski wrote:
On 10/01/2023 13:13, devi priya wrote:
Adding support for the global clock controller found on
IPQ9574 based devices
Subject: drop second/last, redundant "bindings descriptions for". The
"dt-bindings" prefix is already stating that these are bindings.
Sure, will do
Co-developed-by: Anusha Rao <quic_anusha@xxxxxxxxxxx>
Signed-off-by: Anusha Rao <quic_anusha@xxxxxxxxxxx>
Signed-off-by: devi priya <quic_devipriy@xxxxxxxxxxx>
---
.../bindings/clock/qcom,gcc-other.yaml | 4 +
.../devicetree/bindings/clock/qcom,gcc.yaml | 9 +-
include/dt-bindings/clock/qcom,gcc-ipq9574.h | 226 ++++++++++++++++++
include/dt-bindings/reset/qcom,gcc-ipq9574.h | 164 +++++++++++++
4 files changed, 402 insertions(+), 1 deletion(-)
create mode 100644 include/dt-bindings/clock/qcom,gcc-ipq9574.h
create mode 100644 include/dt-bindings/reset/qcom,gcc-ipq9574.h
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml
index 2e8acca64af1..cc563d640336 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc-other.yaml
@@ -18,6 +18,8 @@ description: |
include/dt-bindings/clock/qcom,gcc-ipq4019.h
include/dt-bindings/clock/qcom,gcc-ipq6018.h
include/dt-bindings/reset/qcom,gcc-ipq6018.h
+ include/dt-bindings/clock/qcom,gcc-ipq9574.h
+ include/dt-bindings/reset/qcom,gcc-ipq9574.h
include/dt-bindings/clock/qcom,gcc-msm8953.h
include/dt-bindings/clock/qcom,gcc-mdm9607.h
include/dt-bindings/clock/qcom,gcc-mdm9615.h
@@ -34,6 +36,8 @@ properties:
- qcom,gcc-mdm9607
- qcom,gcc-msm8953
- qcom,gcc-mdm9615
+ - qcom,gcc-ipq9574
Incorrect order but anyway let's switch to new naming style just like
SM8550 and SA8775p.
okay
+
Not related change.
Understood, will remove
required:
- compatible
diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
index 7129fbcf2b6c..5a71268538e6 100644
--- a/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,gcc.yaml
@@ -24,6 +24,14 @@ properties:
'#power-domain-cells':
const: 1
+ clocks:
+ minItems: 1
+ maxItems: 8
+
+ clock-names:
+ minItems: 1
+ maxItems: 8
This does not look correct, neither related.
Okay
+
reg:
maxItems: 1
@@ -35,7 +43,6 @@ required:
- reg
- '#clock-cells'
- '#reset-cells'
- - '#power-domain-cells'
Eee? Why? What's this?
Sure, will address it accordingly
Best regards,
Krzysztof
Best regards,
Devi Priya
