Hi Sinthu, On 10/01/23 16:30, Sinthu Raja wrote: > From: Sinthu Raja <sinthu.raja@xxxxxx> > > AM68 Starter Kit (SK) is a low cost, small form factor board designed > for TI’s AM68 SoC. TI’s AM68 SoC comprises of dual core A72, high > performance vision accelerators, hardware accelerators, latest C71x > DSP, high bandwidth real-time IPs for capture and display. The SoC is > power optimized to provide best in class performance for industrial > applications. > > AM68 SK supports the following interfaces: > * 16 GB LPDDR4 RAM > * x1 Gigabit Ethernet interface > * x1 USB 3.1 Type-C port > * x2 USB 3.1 Type-A ports > * x1 PCIe M.2 M Key > * 512 Mbit OSPI flash > * x2 CSI2 Camera interface (RPi and TI Camera connector) > * 40-pin Raspberry Pi GPIO header > > SK's System on Module (SoM) contains the SoC and DDR. > Therefore, add DT node for the SOC and DDR on the SoM. > > Schematics: https://www.ti.com/lit/zip/SPRR463 > TRM: http://www.ti.com/lit/pdf/spruj28 > > Signed-off-by: Sinthu Raja <sinthu.raja@xxxxxx> > --- > > Changes in V3: > ============= > Addressed review comments > - Removed the unused nodes that are disabled by default. > OSPI support will be added once the OSPI node is enabled for J721s2/AM68 in main DTSI. > > Changes in V2: > ============= > Address review comments > - drop the empty lines. > > V1: https://lore.kernel.org/linux-arm-kernel/20221018123849.23695-3-sinthu.raja@xxxxxx/ > V2: https://lore.kernel.org/lkml/20221107123852.8063-3-sinthu.raja@xxxxxx/ > > arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi | 31 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi > > diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi > new file mode 100644 > index 000000000000..c35f81edee8c > --- /dev/null > +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi > @@ -0,0 +1,31 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2023 Texas Instruments Incorporated - https://www.ti.com/ > + */ > + > +/dts-v1/; > + > +#include "k3-j721s2.dtsi" > +#include <dt-bindings/gpio/gpio.h> > + > +/ { > + memory@80000000 { > + device_type = "memory"; > + /* 16 GB RAM */ > + reg = <0x00 0x80000000 0x00 0x80000000>, > + <0x08 0x80000000 0x03 0x80000000>; > + }; > + > + /* Reserving memory regions still pending */ Is this comment needed? > + reserved_memory: reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + secure_ddr: optee@9e800000 { > + reg = <0x00 0x9e800000 0x00 0x01800000>; > + alignment = <0x1000>; Is alignment needed here? Please see https://lore.kernel.org/lkml/cd5dbbb0-2d9f-8d7d-b051-f8d01d710c62@xxxxxx/ > + no-map; > + }; > + }; > +}; -- Regards, Vaishnav
