On 13/01/2023 07:22, Judy Hsiao wrote: > Add DisplayPort sound node and lpass_cpu node > in sc7280-herobrine-audio-rt5682.dtsi. This we see from diff. You should explain stuff which is not easily visible, e.g. why you are doing it, what do you want to achieve. > > Signed-off-by: Judy Hsiao <judyhsiao@xxxxxxxxxxxx> > > --- > Changes Since v1: > -- Fix the commit message. > > > (no changes since v1) > > .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > index af685bc35e10..69e7aa7b2f6c 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > @@ -33,9 +33,22 @@ codec { > }; > > dai-link@1 { > - link-name = "ALC5682"; > + link-name = "DisplayPort"; This change is still not explained in commit msg. Best regards, Krzysztof