On Tue, Jan 10, 2023 at 10:49:36AM +0100, Krzysztof Kozlowski wrote: > On 10/01/2023 05:25, clayc@xxxxxxx wrote: > > From: Clay Chang <clayc@xxxxxxx> > > > > Document binding to support SROM driver in GXP. > > > > Signed-off-by: Clay Chang <clayc@xxxxxxx> > > --- > > .../bindings/soc/hpe/hpe,gxp-srom.yaml | 36 +++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml > > > > diff --git a/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml b/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml > > new file mode 100644 > > index 000000000000..14ad97d595c8 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/hpe/hpe,gxp-srom.yaml > > Don't drop stuff to soc. Put it in respective directories. This also > applies to your driver. > > SROM controllers go to memory-controllers. What is this, I have no clue. > "SROM Control Register" is not helping me. > > > @@ -0,0 +1,36 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/hpe/hpe,gxp-srom.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: HPE GXP SoC SROM Control Register > > + > > +maintainers: > > + - Clay Chang <clayc@xxxxxxx> > > + > > +description: |+ > > + The SROM control register can be used to configure LPC related legacy > > + I/O registers. > > And why this is a hardware? No, you now add fake devices to be able to > write some stuff from user-space... Otherwise this needs proper hardware > description. Thank you for commenting on this. You are right, this is not a real hardware device, but simply exposes MMIO regions to the user-space. Maybe we should rewrite this as a syscon driver. Is writing a syscon driver a right direction? > > > + > > +properties: > > + compatible: > > + items: > > Drop items, you have only one item. > > > + - const: hpe,gxp-srom > > + > > + reg: > > + items: > > + - description: SROM LPC Configuration Registers > > Drop items and description. Just maxItems: 1 > > > + > > +required: > > + - compatible > > + - reg > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + srom: srom@80fc0000 { > > + compatible = "hpe,gxp-srom"; > > + reg = <0x80fc0000 0x100>; > > + }; > > Best regards, > Krzysztof > Thanks, Clay
