On Wed, 11 Jan 2023 10:23:20 +0100 Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 10/01/2023 17:01, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > > > Add device tree bindings document for the Texas Instruments ADS7924 > > ADC. > > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > Please test the bindings before sending. It's better to use tools for > review than humans... we are all quite busy. Hi, will do from now on. > > --- > > .../bindings/iio/adc/ti,ads7924.yaml | 104 ++++++++++++++++++ > > 1 file changed, 104 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml b/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > > new file mode 100644 > > index 000000000000..a9d3e8778d11 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/iio/adc/ti,ads7924.yaml > > @@ -0,0 +1,104 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/iio/adc/ti,ads7924.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: TI ADS7924 4 channels 12 bits I2C analog to digital converter > > + > > +maintainers: > > + - Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > + > > +description: | > > + Texas Instruments ADS7924 4 channels 12 bits I2C analog to digital converter > > + > > + Specifications: > > + https://www.ti.com/lit/gpn/ads7924 > > + > > +properties: > > + compatible: > > + const: ti,ads7924 > > + > > + reg: > > + maxItems: 1 > > + > > + vref-supply: > > + description: > > + The regulator supply for the ADC reference voltage (AVDD) > > + > > + reset-gpios: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > + > > + "#io-channel-cells": > > + const: 1 > > + > > +required: > > + - compatible > > + - reg > > + - vref-supply > > + - "#address-cells" > > + - "#size-cells" > > + > > +patternProperties: > > Put it before "required:" block. Done. > > > + "^channel@[0-3]+$": > > + $ref: "adc.yaml" > > Drop quotes. Done. > > > + type: object > > + description: | > > + Represents the external channels which are connected to the ADC. > > + > > + properties: > > + reg: > > + description: | > > + The channel number. It can have up to 4 channels numbered from 0 to 3. > > + items: > > + - minimum: 0 > > + maximum: 3 > > Test your bindings, so you will see error here of missing label: true. Added label. > > > + > > + required: > > + - reg > > + > > + additionalProperties: false > > + > > Missing additionalProperties: false. Added. > > > +examples: > > + - | > > + i2c { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + adc@48 { > > + compatible = "ti,ads7924"; > > + reg = <0x48>; > > + vref-supply = <&ads7924_reg>; > > + reset-gpios = <&gpio 5 GPIO_ACTIVE_LOW>; > > + interrupts = <25 IRQ_TYPE_EDGE_FALLING>; > > + interrupt-parent = <&gpio>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + channel@0 { > > + reg = <0>; > > + label = "CH0"; > > + }; > > + channel@1 { > > + reg = <1>; > > + label = "CH1"; > > + }; > > + channel@2 { > > + reg = <2>; > > + label = "CH2"; > > + }; > > + channel@3 { > > + reg = <3>; > > + label = "CH3"; > > + }; > > + }; > > + }; > > +... > > Best regards, > Krzysztof -- Hugo Villeneuve <hugo@xxxxxxxxxxx>
