Hi Sjoerd, Couple of comments which I failed to notice on v2, sorry On 1/11/2023 6:53 PM, Sjoerd Simons wrote: > From: Aswath Govindraju <a-govindraju@xxxxxx> > > AM62 SoC has two instances of USB and they are brought on to the board > in the following way, > > -> USB0 instance > - This is brought out to a USB TypeC connector on board through TPS6598 PD > controller. The PD controller should decide the role based on CC pin in > the connector. Unfortunately the irq line for the TPS isn't hooked up > which is a mode not yet support by the driver (some patches were > submitted earlier this year[0]). So for now the PD controller is left > out and periphal mode chosen. s/periphal/peripheral > > -> USB1 instance > - This is brought out to a USB TypeA connector on board. > > Therefore, add the required device tree support for the above in the board > dts file. > > 0: https://lore.kernel.org/lkml/f714ee55-ef47-317d-81b9-57020dda064b@xxxxxx/T/ > > Signed-off-by: Aswath Govindraju <a-govindraju@xxxxxx> > Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx> > [merge from vendor bsp, drop TPS6598 support, reword commit message] > Signed-off-by: Sjoerd Simons <sjoerd@xxxxxxxxxxxxx> > Tested-by: Martyn Welch <martyn.welch@xxxxxxxxxxxxx> > > --- > > Changes in v3: > - Rebased against current ti-next aka 6.2-rc1 > - Add Martyn's tested-by > > Changes in v2: > - Rebase against linux-next 20221220 > > arch/arm64/boot/dts/ti/k3-am625-sk.dts | 50 ++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > [...] > + > +&ecap0 { > + status = "disabled"; > +}; > + > +&ecap1 { > + status = "disabled"; > +}; > + > +&ecap2 { > + status = "disabled"; > +}; > + > +&main_mcan0 { > + status = "disabled"; > +}; > + > +&epwm0 { > + status = "disabled"; > +}; > + > +&epwm1 { > + status = "disabled"; > +}; > + > +&epwm2 { > + status = "disabled"; > +}; > + Unlike downstream vendor kernel, these nodes are "disabled" by default in k3-am62-main.dtsi. So, these can be dropped. > +&usbss0 { > + ti,vbus-divider; > +}; > + > +&usb0 { > + dr_mode = "peripheral"; > +}; > + > +&usb1 { > + dr_mode = "host"; > + pinctrl-names = "default"; > + pinctrl-0 = <&main_usb1_pins_default>; > +}; Regards Vignesh
