Hi Neil, On Mon, Jan 9, 2023 at 1:53 PM Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote: [...] > + compatible: > + oneOf: > + - enum: > + - amlogic,meson6-wdt > + - amlogic,meson8-wdt Technically this is not an identical representation of what we had before which was: - "amlogic,meson8-wdt" and "amlogic,meson6-wdt" on Meson8 SoCs We're not using the "amlogic,meson8-wdt" compatible anywhere at the moment. In the meson_wdt driver it's defined with the same per-SoC data as "amlogic,meson6-wdt". Long story short: In my opinion there's no need to change what you have right now. If you have to re-spin this then maybe you can add a note to the patch description. Please add my: Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> Best regards, Martin
