On 10.01.2023 14:42, Bryan O'Donoghue wrote: > On 10/01/2023 13:24, Krzysztof Kozlowski wrote: >> On 10/01/2023 14:14, Bryan O'Donoghue wrote: >>> On 03/01/2023 09:14, Krzysztof Kozlowski wrote: >>>> ../arch/arm64/boot/dts/qcom/msm8939.dtsi:1825.23-1842.5: Warning >>>> (simple_bus_reg): /soc@0/mmc@7824000: simple-bus unit address format >>>> error, expected "7824900 >>> >>> For the record the driver consuming this dt entry requires the host regs >>> to come first followed by the core >>> >>> sdhc_1: mmc@7824000 { >>> compatible = "qcom,msm8916-sdhci", "qcom,sdhci-msm-v4"; >>> reg = <0x07824900 0x11c>, <0x07824000 0x800>; >>> reg-names = "hc", "core"; >>> } >>> >>> If I change this and the msm8916 to >> >> That's not the solution. The warning is saying that unit address does >> not match your reg. You need to correct unit address. >> >> Best regards, >> Krzysztof >> > > Is it not the case that the unit-address should match the first reg Yes and that the first reg should also be the lowest address ? Depends on what the first reg is, bindings usually dictate the order. Konrad > > --- > bod