Hi Chester, thanks for your patch! On Wed, Dec 21, 2022 at 8:33 AM Chester Lin <clin@xxxxxxxx> wrote: > Add the pinctrl driver for NXP S32 SoC family. This driver is mainly based > on NXP's downstream implementation on CodeAurora[1]. > > [1] https://source.codeaurora.org/external/autobsps32/linux/tree/drivers/pinctrl/freescale?h=bsp34.0-5.10.120-rt > > Signed-off-by: Matthew Nunez <matthew.nunez@xxxxxxx> > Signed-off-by: Phu Luu An <phu.luuan@xxxxxxx> > Signed-off-by: Stefan-Gabriel Mirea <stefan-gabriel.mirea@xxxxxxx> > Signed-off-by: Larisa Grigore <larisa.grigore@xxxxxxx> > Signed-off-by: Ghennadi Procopciuc <Ghennadi.Procopciuc@xxxxxxxxxxx> > Signed-off-by: Andrei Stefanescu <andrei.stefanescu@xxxxxxx> > Signed-off-by: Radu Pirea <radu-nicolae.pirea@xxxxxxx> > Signed-off-by: Chester Lin <clin@xxxxxxxx> (...) > drivers/pinctrl/freescale/Kconfig | 14 + > drivers/pinctrl/freescale/Makefile | 2 + > drivers/pinctrl/freescale/pinctrl-s32.h | 76 ++ > drivers/pinctrl/freescale/pinctrl-s32cc.c | 983 ++++++++++++++++++++++ > drivers/pinctrl/freescale/pinctrl-s32g2.c | 773 +++++++++++++++++ Should this driver really be grouped together with the legacy branded "freescale" stuff? Does it share any hardware or structure or code with the Freescale drivers? Maybe you should bite the bullet and created drivers/pinctrl/nxp? Also create a new MAINTAINERS entry so we do not get the Freescale legacy maintainer list. Overall the driver looks good, I am a bit sceptic about the things that Kryzstof is talking about as well so that needs to be resolved. Yours, Linus Walleij
