On 04/01/2023 12:53, Stephan Gerhold wrote:
> The soc_id array is mostly ordered by the numeric "msm-id" defined in
> qcom,ids.h but some recent entries were added at the wrong place.
>
> While it does not make a functional difference it does make it harder
> to regenerate the entire array after adding a bunch of new IDs.
>
> Fixes: de320c07da3d ("soc: qcom: socinfo: Add MSM8956/76 SoC IDs to the soc_id table")
> Fixes: 147f6534b8ff ("soc: qcom: socinfo: Add SM8550 ID")
> Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
> ---
> drivers/soc/qcom/socinfo.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 10efdbcfdf05..7258527816b0 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -257,8 +257,6 @@ static const struct soc_id soc_id[] = {
Can you in the same or new patch add a comment that list is ordered by
numerical ID, not by model name?
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
Best regards,
Krzysztof
