Re: [PATCH v2 2/3] dt-bindings: remoteproc: qcom,sm8150-pas: Add SM6375 CDSP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/01/2023 13:06, Konrad Dybcio wrote:
> Add entries for SM6375 CDSP, as it's essentially identical to the one
> on SM8150.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
> v1 -> v2:
> - Rebase on top of recent changes, move to 8150 pas yaml
> 
>  .../devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml        | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
> index b934252cf02b..082ae70a3fcb 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
> @@ -16,6 +16,7 @@ description:
>  properties:
>    compatible:
>      enum:
> +      - qcom,sm6375-cdsp-pas
>        - qcom,sm8150-adsp-pas
>        - qcom,sm8150-cdsp-pas
>        - qcom,sm8150-mpss-pas

I don't think it is maintainable to keep sm6375 once here and once in
sm6350 file. If it does not fit one family, then probably it deserves
its own file.

Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux