Hi Angelo, On Mon, Dec 26, 2022 at 03:07:10PM +0800, Chen-Yu Tsai wrote: > On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno > <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote: > > > > Take a pointer to a struct device in mtk_clk_register_cpumuxes() and > > propagate the same to mtk_clk_register_cpumux() => clk_hw_register(). > > Even though runtime pm is unlikely to be used with CPU muxes, this > > helps with code consistency and possibly opens to commonization of > > some mtk_clk_register_(x) functions. > > > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > > Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx> > > As with the gates patch, could we make the |struct device *| parameter the > first one? Also for this case I think we could even drop the > |struct device_node *| parameter. Reviewed-by: Markus Schneider-Pargmann <msp@xxxxxxxxxxxx> clk_hw_register and others are using the device pointer as first parameter as well. So I think it makes sense to do it the same way as ChenYu suggested. Best, Markus
