On 07/01/2023 01.26, Mark Brown wrote: > On Wed, Jan 04, 2023 at 06:36:29PM +0900, Janne Grunau wrote: > >> 65us is not a reasonable maximum for this property, as some devices >> might need a much longer setup time (e.g. those driven by firmware on >> the other end). Plus, device tree property values are in 32-bit cells >> and smaller widths should not be used without good reason. > > This breaks allmodconfig builds (I tested x86 but this should happen > for anything with -Werror): > > /build/stage/linux/drivers/spi/spi.c: In function ‘of_spi_parse_dt’: > /build/stage/linux/drivers/spi/spi.c:2243:13: error: unused variable ‘cs_setup’ [-Werror=unused-variable] > 2243 | u16 cs_setup; > | ^~~~~~~~ > cc1: all warnings being treated as errors Yeah, the kernel test robot caught this one too. Sorry for missing it (it got buried in warning noise in a rather large rebuild on my side). That line should've been removed in #3 :( I see two patches got applied already. Do you want me to just respin #3-#5? - Hector
