On 03/01/2023 02:09, Bryan O'Donoghue wrote: > The apq8039-t2 is an apq8039 based board paired with a wcn3680b WiFi > chipset. > > Co-developed-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > Co-developed-by: Jun Nie <jun.nie@xxxxxxxxxx> > Signed-off-by: Jun Nie <jun.nie@xxxxxxxxxx> > Co-developed-by: Benjamin Li <benl@xxxxxxxxxxxx> (...) > + > +&blsp_i2c2 { > + status = "okay"; > +}; > + > +&blsp_i2c3 { > + status = "okay"; Blank line. > + tps6598x: tps6598x@38 { Node names should be generic. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "ti,tps6598x"; > + reg = <0x38>; > + Best regards, Krzysztof