On Mon, Jan 02, 2023 at 04:09:59PM +0100, Krzysztof Kozlowski wrote: > On 02/01/2023 16:05, Johan Hovold wrote: > > On Mon, Jan 02, 2023 at 01:24:34PM +0100, Krzysztof Kozlowski wrote: > >> On 02/01/2023 13:23, Krzysztof Kozlowski wrote: > >>> On 02/01/2023 11:50, Johan Hovold wrote: > >>>> The wcd938x codec is not a memory-mapped device and does not belong > >>>> under the soc node. > >>>> > >>>> Move the node to the root node to avoid DT validation failures. > >>>> > >>>> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > >>>> --- > >>>> arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 52 ++++++++++++------------- > >>>> 1 file changed, 25 insertions(+), 27 deletions(-) > >>>> > >>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > >>>> index 4de3e1f1c39c..217b2c654745 100644 > >>>> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > >>>> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts > >>>> @@ -17,6 +17,31 @@ aliases { > >>>> serial0 = &uart7; > >>>> }; > >>>> > >>>> + wcd938x: codec { > >>> > >>> Let's call it audio-codec and put it somewhere ordered alphabetically. > >>> This avoids useless reshuffles immediately. Moving things back and forth > >>> does not make sense. > >> > >> Eh, on the other hand SM8250-MTP uses name codec so maybe the rename in > >> SC8280xp should be dropped. > > > > Nah, let's go with audio-codec. Your MTP change hasn't been merged yet > > so we can still drop or respin that one. > > It was, ~5 days ago, so please rebase. Again, not in the qcom tree yet AFAICS. Johan