Hi,
Am 04.11.2014 um 14:33 schrieb Ivan T. Ivanov:
> Update compatible string with runtime detected chip revision
> information, for example qcom,pm8941 will become qcom,pm8941-v1.0.
That's not what the patch does though?
>
> Signed-off-by: Ivan T. Ivanov <iivanov@xxxxxxxxxx>
> ---
> .../devicetree/bindings/mfd/qcom,spmi-pmic.txt | 18 ++-
> drivers/mfd/qcom-spmi-pmic.c | 142 +++++++++++++++++++++
> 2 files changed, 156 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> index 7182b88..bbe7db8 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt
> @@ -15,10 +15,20 @@ each. A function can consume one or more of these fixed-size register regions.
>
> Required properties:
> - compatible: Should contain one of:
> - "qcom,pm8941"
> - "qcom,pm8841"
> - "qcom,pma8084"
> - or generalized "qcom,spmi-pmic".
> + qcom,pm8941,
> + qcom,pm8841,
> + qcom,pm8019,
> + qcom,pm8226,
> + qcom,pm8110,
> + qcom,pma8084,
> + qcom,pmi8962,
> + qcom,pmd9635,
> + qcom,pm8994,
> + qcom,pmi8994,
> + qcom,pm8916,
> + qcom,pm8004,
> + qcom,pm8909,
Please either keep the strings consistently quoted, or drop the trailing
comma to avoid any confusion of where it terminates.
> + or generalized "qcom,spmi-pmic".
> - reg: Specifies the SPMI USID slave address for this device.
> For more information see:
> Documentation/devicetree/bindings/spmi/spmi.txt
Regards,
Andreas
[...]
> @@ -45,7 +177,17 @@ static const struct of_device_id pmic_spmi_id_table[] = {
> { .compatible = "qcom,spmi-pmic" },
> { .compatible = "qcom,pm8941" },
> { .compatible = "qcom,pm8841" },
> + { .compatible = "qcom,pm8019" },
> + { .compatible = "qcom,pm8226" },
> + { .compatible = "qcom,pm8110" },
> { .compatible = "qcom,pma8084" },
> + { .compatible = "qcom,pmi8962" },
> + { .compatible = "qcom,pmd9635" },
> + { .compatible = "qcom,pm8994" },
> + { .compatible = "qcom,pmi8994" },
> + { .compatible = "qcom,pm8916" },
> + { .compatible = "qcom,pm8004" },
> + { .compatible = "qcom,pm8909" },
> { }
> };
> MODULE_DEVICE_TABLE(of, pmic_spmi_id_table);
--
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 21284 AG Nürnberg
Attachment:
signature.asc
Description: OpenPGP digital signature
