On Mon, 2 Jan 2023 at 00:51, Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> On Sun, Jan 1, 2023 at 3:46 PM Dmitry Baryshkov
> <dmitry.baryshkov@xxxxxxxxxx> wrote:
>
> > + mdio {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + phy0: ethernet-phy@0 {
> > + reg = <0>;
> > + device_type = "ethernet-phy";
>
> I forgot to comment on this one in the previous review:
> device_type = "ethernet-phy" does not look like a valid property.
Well, it's used by the kernel, but I can drop it.
>
> > +&vpu {
> > + status = "okay";
> > +};
>
> This can be removed, as the vpu node is not disabled in imx53.dtsi.
Ugh. I thought that I removed it after v1 based on your feedback.
--
With best wishes
Dmitry
