Re: [PATCH v6 07/20] thermal/drivers/tsens: fix slope values for msm8939

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/01/2023 21:30, Dmitry Baryshkov wrote:
On 01/01/2023 22:24, Bryan O'Donoghue wrote:
On 01/01/2023 19:40, Dmitry Baryshkov wrote:
+static int __init init_8939(struct tsens_priv *priv) {
+    priv->sensor[0].slope = 2911;
+    priv->sensor[1].slope = 2789;
+    priv->sensor[2].slope = 2906;
+    priv->sensor[3].slope = 2763;
+    priv->sensor[4].slope = 2922;
+    priv->sensor[5].slope = 2867;
+    priv->sensor[6].slope = 2833;
+    priv->sensor[7].slope = 2838;
+    priv->sensor[8].slope = 2840;
+    priv->sensor[9].slope = 2852;

How are you coming up with the last value here ?

https://github.com/android-linux-stable/msm-3.18/blob/60a8d8af3751b9dc22894fe68b3964ea94ae7888/arch/arm/boot/dts/qcom/msm8939-common.dtsi#L525

From this DTSi. There was a separate configuration for 8939 v3. And I don't know why Qualcomm completely ignored it for later releases (3.14, 3.18).

https://git.codelinaro.org/clo/la/kernel/msm-3.10/-/blob/LA.BR.1.3.7.c26-03900-8976.0/arch/arm/boot/dts/qcom/msm8939-v3.0.dtsi#L613


Fair enough

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux