Re: [PATCH] ARM: dts: imx: Add support for SK-iMX53 board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Dmitry,

On Sat, Dec 31, 2022 at 9:49 PM Dmitry Baryshkov
<dmitry.baryshkov@xxxxxxxxxx> wrote:

> +/ {
> +       model = "StarterKit SK-iMX53 Board";
> +       compatible = "starterkit,sk-imx53", "fsl,imx53";
> +
> +       aliases {
> +               /*
> +                * iMX RTC is not battery powered on this boart.

s/boart/board

> +&fec {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_fec>;
> +       phy-mode = "rmii";
> +       phy-reset-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>;

This property is deprecated. It is better to pass the standard
'reset-gpios' property inside the mdio node.

> +       phy-handle = <&phy0>;
> +       mac-address = [000000000000]; /* placeholder; will be overwritten by bootloader */
> +       status = "okay";
> +
> +       mdio {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +
> +               phy0: ethernet-phy@0 {
> +                       reg = <0>;
> +                       device_type = "ethernet-phy";
> +               };
> +       };
> +};

> +
> +&iomuxc {
> +       pinctrl_audmux: audmuxgrp {
> +               fsl,pins = <
> +                       MX53_PAD_SD2_DATA3__AUDMUX_AUD4_TXC     0x80000000

Please use the real pinctrl value instead of 0x80000000.

The same applies globally.

> +&vpu {
> +       status = "okay";
> +};

No need to enable the vpu node here as it is not disabled in imx53.dtsi.



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux