Re: [PATCH v2 8/9] PCI: microchip: Partition inbound address translation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 22, 2022 at 01:30:03PM +0800, kernel test robot wrote:
> ...
> All warnings (new ones prefixed by >>):
> 
>    drivers/pci/controller/pcie-microchip-host.c:896:32: warning: cast from 'void (*)(struct clk *)' to 'void (*)(void *)' converts to incompatible function type [-Wcast-function-type-strict]
>            devm_add_action_or_reset(dev, (void (*) (void *))clk_disable_unprepare,
>                                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I know this particular warning wasn't added by *this* series, but of
600+ instances of devm_add_action_or_reset(), only 4 have similar cast
ugliness like this.  I think most others define a trivial stub that
takes a void * and passes it on to the underlying function that
expects a more specific type.  That's kind of ugly too, but arguably
a little less so.

Bjorn



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux