On Fri, Dec 23, 2022 at 5:43 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote: > > This driver is using CLK_OF_DECLARE() for all clocks: while this > definitely works, it's not preferred as this makes it impossible > to compile non boot critical clock drivers as modules and to take > advantage of clock controller Runtime PM. > > As a preparation for a larger cleanup, migrate all of the clock > controller drivers for MT8173 to platform_driver and use the > common mtk_clk_simple_probe() where possible. Should also mention that proper error handling was added. Otherwise, Reviewed-by: Chen-Yu Tsai <wenst@xxxxxxxxxxxx>
