>In preparation for commonizing topckgen probe on various MediaTek SoCs >clock drivers, add the ability to register the MFG MUX notifier in >mtk_clk_simple_probe() by passing a custom notifier register function >pointer, as this function will be slightly different across different >SoCs. > >Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> >--- > drivers/clk/mediatek/clk-mtk.c | 8 ++++++++ > drivers/clk/mediatek/clk-mtk.h | 3 +++ > 2 files changed, 11 insertions(+) > >diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c >index b0a6225cd7b2..df6281492fb6 100644 >--- a/drivers/clk/mediatek/clk-mtk.c >+++ b/drivers/clk/mediatek/clk-mtk.c >@@ -533,6 +533,14 @@ int mtk_clk_simple_probe(struct platform_device *pdev) > goto unregister_composites; > } > >+ if (mcd->clk_notifier_func) { >+ struct clk *mfg_mux = clk_data->hws[mcd->mfg_clk_idx]->clk; >+ >+ r = mcd->clk_notifier_func(&pdev->dev, mfg_mux); >+ if (r) >+ goto unregister_clks; >+ } Should we have a IS_ERR_OR_NULL() check for clk_data->hws[mcd->mfg_clk_idx]? thanks, Miles >+ > r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data); > if (r)