On 2022-12-27 19:38:10, Dzmitry Sankouski wrote:
> resin node was moved to pm8998.dtsi file, and introduced duplication
> with other dts files, defining resin node.
This is fixing the right thing for the wrong reasons. As mentioned in
my report these nodes did not previously have status="okay" and ended up
disabled after your patch, which is much more important than a few
duplicate properties that were left in place.
Please resend with a commit message that carries this load. The title
could/should contain something like "Re-enable resin on MSM8998 and
SDM845 boards". After that you can add my:
Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> Fixes: f86ae6f23a9e ("arm64: dts: qcom: sagit: add initial device tree for sagit")
> Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx>
You forgot to CC me, which would have happened automatically if you
added:
Reported-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> # https://lore.kernel.org/linux-arm-msm/20221222115922.jlachctn4lxopp7a@xxxxxxxxxxxxxx/
Aside that, thanks a lot for caring about your patches and sending this
fixup!
- Marijn
