On 26/12/2022 14:49, Javier Martinez Canillas wrote: > Add device tree bindings for panels based on the Himax HX8394 controller, > such as the HannStar HSD060BHW4 720x1440 TFT LCD panel that is connected > through a MIPI-DSI video interface. > > Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- > > Changes in v2: > - Drop redundant "bindings" in subject (Krzysztof Kozlowski). > - Drop "device tree bindings" in title (Krzysztof Kozlowski). > - Put port next to other "true" properties (Krzysztof Kozlowski). > - Add Krzysztof Kozlowski's Reviewed-by tag. > > .../bindings/display/panel/himax,hx8394.yaml | 65 +++++++++++++++++++ > 1 file changed, 65 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml > > diff --git a/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml > new file mode 100644 > index 000000000000..bead3f0b05c5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/himax,hx8394.yaml > @@ -0,0 +1,65 @@ > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/himax,hx8394.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Himax HX8394 MIPI-DSI LCD panel controller > + > +maintainers: > + - Javier Martinez Canillas <javierm@xxxxxxxxxx> > + > +description: > + Device tree bindings for panels based on the Himax HX8394 controller, > + such as the HannStar HSD060BHW4 720x1440 TFT LCD panel connected with > + a MIPI-DSI video interface. > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + enum: > + # HannStar HSD060BHW4 5.99" 720x1440 TFT LCD panel > + - hannstar,hsd060bhw4 > + > + vcc-supply: > + description: Panel power supply > + > + iovcc-supply: > + description: I/O voltage supply > + > + port: true > + > + reset-gpios: true > + > + backlight: true > + > +required: > + - compatible > + - vcc-supply > + - iovcc-supply > + - port Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
