Hi Jagan, Thanks for the review comments. On Mon, 26 Dec 2022 at 15:20, Jagan Teki <jagan@xxxxxxxxxx> wrote: > > On Mon, 26 Dec 2022 at 12:07, Anand Moon <anand@xxxxxxxxxx> wrote: > > > > Rockchip RV1126 has GMAC 10/100/1000M ethernet controller > > add GMAC node for RV1126 SoC. > > > > Signed-off-by: Anand Moon <anand@xxxxxxxxxx> > > --- > > drop SoB of Jagan Teki > > --- > > arch/arm/boot/dts/rv1126.dtsi | 63 +++++++++++++++++++++++++++++++++++ > > 1 file changed, 63 insertions(+) > > > > diff --git a/arch/arm/boot/dts/rv1126.dtsi b/arch/arm/boot/dts/rv1126.dtsi > > index 1cb43147e90b..bae318c1d839 100644 > > --- a/arch/arm/boot/dts/rv1126.dtsi > > +++ b/arch/arm/boot/dts/rv1126.dtsi > > @@ -90,6 +90,69 @@ xin24m: oscillator { > > #clock-cells = <0>; > > }; > > > > + gmac_clkin_m0: external-gmac-clockm0 { > > + compatible = "fixed-clock"; > > + clock-frequency = <125000000>; > > + clock-output-names = "clk_gmac_rgmii_clkin_m0"; > > + #clock-cells = <0>; > > + }; > > + > > + gmac_clkini_m1: external-gmac-clockm1 { > > + compatible = "fixed-clock"; > > + clock-frequency = <125000000>; > > + clock-output-names = "clk_gmac_rgmii_clkin_m1"; > > + #clock-cells = <0>; > > + }; > > These seems not needed, Ok, I will drop this in next version. Thanks -Anand