Hi Thomas, [...] > +static int mvebu_pm_enter(suspend_state_t state) > +{ > + if (state != PM_SUSPEND_MEM) > + return -EINVAL; > + > + cpu_pm_enter(); > + cpu_cluster_pm_enter(); Why do you use this function? It notifies the listeners with CPU_CLUSTER_PM_ENTER but currently only omap2 and the gic are waiting for it. Do you already plan to be compatible with the cortex A9 based mvebu SoC? By the way the gic doesn't use the suspend and resume operation from syscore_ops but the notification. Is there any particular reason for using syscore_ops in the irq-armada-370-xp driver? Thanks, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html