On Monday 03 November 2014 11:45:44 Iyappan Subramanian wrote:
>
> On Thu, Oct 30, 2014 at 3:13 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > On Wednesday 29 October 2014 17:56:19 Iyappan Subramanian wrote:
> >> @@ -621,7 +621,7 @@
> >> };
> >> };
> >>
> >> - sgenet0: ethernet@1f210000 {
> >> + sgenet0: sgenet@1f210000 {
> >> compatible = "apm,xgene-enet";
> >> status = "disabled";
> >> reg = <0x0 0x1f210000 0x0 0x10000>,
> >>
> >
> > This looks like you accidentally reverted a bug fix made earlier.
> > Network devices should always have the name 'ethernet@...'.
>
> Thanks for the review. Since our firmware was patching the dtb, based
> on the node-name, we thought by changing node-name, we can avoid the
> patching and maintain backward compatibility.
>
> Now we know that network devices should have 'ethernet@...', we will
> handle the backward compatibility in a different way and will post the
> patch v2 shortly.
It's not important enough to break backwards compatibility over this.
If you can't find a better way to handle compatibility with the old
firmware, just add a comment explaining the node name.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
