On Tue, 20 Dec 2022 22:28:48 +0000, Conor Dooley wrote: > On Tue, Dec 20, 2022 at 08:50:47AM +0800, Hal Feng wrote: > > From: Emil Renner Berthing <kernel@xxxxxxxx> > > > > The StarFive JH7100 SoC has additional reset controllers for audio and > > video, but the registers follow the same structure. On the JH7110 the > > reset registers don't get their own memory range, but instead follow the > > clock control registers. The registers still follow the same structure > > though, so let's factor out the common code to handle all these cases. > > Is it a bit ornery to want to see this as a movement and an extraction > in two different patches? Would prob be easier to follow that way. Definitely, it will be more readable and easier to review. OK, I split it in the next version. Best regards, Hal