On 22/12/2022 12:47, Krzysztof Kozlowski wrote: > On 20/12/2022 13:36, Bryan O'Donoghue wrote: >> Currently we do not differentiate between the various users of the >> qcom,mdss-dsi-ctrl. The driver is flexible enough to operate from one >> compatible string but, the hardware does have some significant differences >> in the number of clocks. >> >> To facilitate documenting the clocks add the following compatible strings >> >> - qcom,apq8064-dsi-ctrl >> - qcom,msm8916-dsi-ctrl >> - qcom,msm8953-dsi-ctrl >> - qcom,msm8974-dsi-ctrl >> - qcom,msm8996-dsi-ctrl >> - qcom,msm8998-dsi-ctrl >> - qcom,sc7180-dsi-ctrl >> - qcom,sc7280-dsi-ctrl >> - qcom,sdm660-dsi-ctrl >> - qcom,sdm845-dsi-ctrl >> - qcom,sm8250-dsi-ctrl >> >> Each SoC dtsi should declare "qcom,socname-dsi-ctrl", "qcom,mdss-dsi-ctrl"; >> >> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> >> --- >> .../display/msm/dsi-controller-main.yaml | 20 +++++++++++++++---- >> 1 file changed, 16 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> index 6e2fd6e9fa7f0..01afa9e9c4b3c 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml >> @@ -14,9 +14,21 @@ allOf: >> >> properties: >> compatible: >> - enum: >> - - qcom,mdss-dsi-ctrl >> - - qcom,dsi-ctrl-6g-qcm2290 >> + items: >> + - enum: >> + - qcom,apq8064-dsi-ctrl >> + - qcom,msm8916-dsi-ctrl >> + - qcom,msm8953-dsi-ctrl >> + - qcom,msm8974-dsi-ctrl >> + - qcom,msm8996-dsi-ctrl >> + - qcom,msm8998-dsi-ctrl >> + - qcom,dsi-ctrl-6g-qcm2290 >> + - qcom,sc7180-dsi-ctrl >> + - qcom,sc7280-dsi-ctrl >> + - qcom,sdm660-dsi-ctrl >> + - qcom,sdm845-dsi-ctrl >> + - qcom,sm8250-dsi-ctrl > > Usual comment: can we keep the list sorted? Actually it is sorted, except the qcom,dsi-ctrl-6g-qcm2290. Please move it after apq. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
