On 21/12/2022 18:30, Gatien Chevallier wrote: > Adds the list of peripherals IDs under firewall bus on STM32MP15. > > Signed-off-by: Gatien Chevallier <gatien.chevallier@xxxxxxxxxxx> > --- > include/dt-bindings/bus/stm32mp15_sys_bus.h | 98 +++++++++++++++++++++ > 1 file changed, 98 insertions(+) > create mode 100644 include/dt-bindings/bus/stm32mp15_sys_bus.h > > diff --git a/include/dt-bindings/bus/stm32mp15_sys_bus.h b/include/dt-bindings/bus/stm32mp15_sys_bus.h > new file mode 100644 > index 000000000000..97eacc7b5f16 > --- /dev/null > +++ b/include/dt-bindings/bus/stm32mp15_sys_bus.h That's wrong in multiple ways: 1. No underscores 2. Missing vendor prefix 3. Name not matching compatible. > @@ -0,0 +1,98 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (C) STMicroelectronics 2022 - All Rights Reserved > + */ > +#ifndef _DT_BINDINGS_BUS_STM32MP15_SYS_BUS_H > +#define _DT_BINDINGS_BUS_STM32MP15_SYS_BUS_H > + > +/* ETZPC IDs */ > +#define STM32MP1_ETZPC_STGENC_ID 0 > +#define STM32MP1_ETZPC_BKPSRAM_ID 1 > +#define STM32MP1_ETZPC_IWDG1_ID 2 > +#define STM32MP1_ETZPC_USART1_ID 3 > +#define STM32MP1_ETZPC_SPI6_ID 4 > +#define STM32MP1_ETZPC_I2C4_ID 5 > +/* ID 6 reserved */ Reserved why? These are IDs so they start from 0 and go by 0. Don't hard-code some register offsets. Best regards, Krzysztof
