On 20/12/2022 11:21, Yuteng Zhong wrote: > LubanCat 1 is a Rockchip RK3566 SBC based > is developed by EmbedFire Electronics Co., Ltd. > Mini Linux Card Type Cheap Computer Development Board Please wrap commit message according to Linux coding style / submission process: https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586 > It has the following characteristics: > - MicroSD card slot, onboard eMMC flash memory > - 1GbE Realtek RTL8211F Ethernet Transceiver > - 1 USB Type-C port (power and USB2.0 OTG) > - 1 USB 3.0 Host port > - 3 USB 2.0 Host ports > - 1 HDMI > - 1 infrared receiver > - 1 MIPI DSI > - 1 MIPI CSI > - 1 x 4-section headphone jack > - Mini PCIe socket (USB or PCIe) > - 1 SIM Card slot > - 1 SYS LED and 1 PWR LED > - 40-pin GPIO expansion header > > Signed-off-by: Yuteng Zhong <zonyitoo@xxxxxxxxx> > Signed-off-by: DHDAXCW <lasstp5011@xxxxxxxxx> > --- > .../devicetree/bindings/arm/rockchip.yaml | 5 + > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../boot/dts/rockchip/rk3566-lubancat-1.dts | 600 ++++++++++++++++++ > 3 files changed, 606 insertions(+) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 88ff4422a8c1..84d39a3a8843 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -781,6 +781,11 @@ properties: > - const: rockchip,rk3568-bpi-r2pro > - const: rockchip,rk3568 > > + - description: EmbedFire LubanCat 1 > + items: > + - const: embedfire,lubancat-1 > + - const: rockchip,rk3566 > + This is separate patch. Does not look like properly ordered. Don't add stuff at the end of files/lists. > additionalProperties: true > > ... > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > index 0a76a2ebb5f6..e52bda04d45a 100644 > --- a/arch/arm64/boot/dts/rockchip/Makefile > +++ b/arch/arm64/boot/dts/rockchip/Makefile > @@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-blade.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts > new file mode 100644 > index 000000000000..af1abb38d45c > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts > @@ -0,0 +1,600 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > +* Copyright (c) 2021 Rockchip Electronics Co., Ltd. > +*/ > + > +/dts-v1/; > +#include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/leds/common.h> > +#include <dt-bindings/pinctrl/rockchip.h> > +#include <dt-bindings/soc/rockchip,vop2.h> > +#include "rk3566.dtsi" > + > +/ { > + model = "EmbedFire LubanCat 1"; > + compatible = "embedfire,lubancat-1", "rockchip,rk3566"; > + > + aliases { > + ethernet0 = &gmac1; > + mmc0 = &sdmmc0; > + mmc1 = &sdhci; > + }; > + > + chosen: chosen { > + stdout-path = "serial2:1500000n8"; > + }; > + > + gmac1_clkin: external-gmac1-clock { > + compatible = "fixed-clock"; > + clock-frequency = <125000000>; > + clock-output-names = "gmac1_clkin"; > + #clock-cells = <0>; > + }; > + > + hdmi-con { > + compatible = "hdmi-connector"; > + type = "a"; > + > + port { > + hdmi_con_in: endpoint { > + remote-endpoint = <&hdmi_out_con>; > + }; > + }; > + }; > + > + gpio-leds { > + compatible = "gpio-leds"; > + > + sys_led: sys-led { > + label = "sys_led"; > + linux,default-trigger = "heartbeat"; > + default-state = "on"; > + gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&sys_led_pin>; > + }; > + }; > + > + dc_5v: dc-5v { Node names should be generic, so at least with regulator prefix or suffix. https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "regulator-fixed"; > + regulator-name = "dc_5v"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + }; > + > + vcc3v3_sys: vcc3v3-sys { > + compatible = "regulator-fixed"; > + regulator-name = "vcc3v3_sys"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + vin-supply = <&vcc5v0_sys>; > + }; > + > + vcc5v0_sys: vcc5v0-sys { > + compatible = "regulator-fixed"; > + regulator-name = "vcc5v0_sys"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <&dc_5v>; > + }; > + > + pcie_3v3: pcie2-3v3-regulator { And here you have it? Keep your code consistent. > + compatible = "regulator-fixed"; > + regulator-name = "pcie_3v3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + enable-active-high; > + gpio = <&gpio0 RK_PD3 GPIO_ACTIVE_HIGH>; > + startup-delay-us = <5000>; > + vin-supply = <&vcc5v0_sys>; > + }; > + > + vcc5v0_usb20_host: vcc5v0-usb20-host-regulator { > + compatible = "regulator-fixed"; > + enable-active-high; > + gpio = <&gpio2 RK_PB6 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&vcc5v0_usb20_host_en>; > + regulator-name = "vcc5v0_usb20_host"; > + regulator-always-on; > + }; > + > + vcc5v0_usb30_host: vcc5v0-usb30-host-regulator { > + compatible = "regulator-fixed"; > + enable-active-high; > + gpio = <&gpio2 RK_PB5 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&vcc5v0_usb30_host_en>; > + regulator-name = "vcc5v0_usb30_host"; > + regulator-always-on; > + }; > +}; > + > +&uart2 { > + status = "okay"; > +}; > + > +&combphy1 { > + status = "okay"; > +}; > + > +&combphy2 { > + status = "okay"; > +}; > + > +&cpu0 { > + cpu-supply = <&vdd_cpu>; > +}; > + > +&cpu1 { > + cpu-supply = <&vdd_cpu>; > +}; > + > +&cpu2 { > + cpu-supply = <&vdd_cpu>; > +}; > + > +&cpu3 { > + cpu-supply = <&vdd_cpu>; > +}; > + > +&gpu { > + mali-supply = <&vdd_gpu>; > + status = "okay"; > +}; > + > +&hdmi { > + avdd-0v9-supply = <&vdda0v9_image>; > + avdd-1v8-supply = <&vcca1v8_image>; > + status = "okay"; > +}; > + > +&hdmi_in { > + hdmi_in_vp0: endpoint { > + remote-endpoint = <&vp0_out_hdmi>; > + }; > +}; > + > +&hdmi_out { > + hdmi_out_con: endpoint { > + remote-endpoint = <&hdmi_con_in>; > + }; > +}; > + > +&hdmi_sound { > + status = "okay"; > +}; > + > +&i2c0 { > + status = "okay"; > + > + vdd_cpu: regulator@1c { > + compatible = "tcs,tcs4525"; > + reg = <0x1c>; > + fcs,suspend-voltage-selector = <1>; > + regulator-name = "vdd_cpu"; > + regulator-always-on; > + regulator-boot-on; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <1150000>; > + regulator-ramp-delay = <2300>; > + vin-supply = <&vcc5v0_sys>; > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + rk809: pmic@20 { > + compatible = "rockchip,rk809"; > + reg = <0x20>; > + interrupt-parent = <&gpio0>; > + interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>; > + assigned-clocks = <&cru I2S1_MCLKOUT_TX>; > + assigned-clock-parents = <&cru CLK_I2S1_8CH_TX>; > + #clock-cells = <1>; > + clock-names = "mclk"; > + clocks = <&cru I2S1_MCLKOUT_TX>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pmic_int>; > + rockchip,system-power-controller; > + #sound-dai-cells = <0>; > + vcc1-supply = <&vcc3v3_sys>; > + vcc2-supply = <&vcc3v3_sys>; > + vcc3-supply = <&vcc3v3_sys>; > + vcc4-supply = <&vcc3v3_sys>; > + vcc5-supply = <&vcc3v3_sys>; > + vcc6-supply = <&vcc3v3_sys>; > + vcc7-supply = <&vcc3v3_sys>; > + vcc8-supply = <&vcc3v3_sys>; > + vcc9-supply = <&vcc3v3_sys>; > + wakeup-source; > + > + regulators { > + vdd_logic: DCDC_REG1 { No underscores in node names. Anything requires it? Best regards, Krzysztof
