On 20/12/2022 14:22, Zeynep Arslanbenzer wrote: > This patch adds binding document for MAX77659 MFD driver. 1. Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 2. Subject: drop second, redundant "binding". > > Signed-off-by: Nurettin Bolucu <Nurettin.Bolucu@xxxxxxxxxx> > Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@xxxxxxxxxx> > --- > .../devicetree/bindings/mfd/adi,max77659.yaml | 70 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 71 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/adi,max77659.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/adi,max77659.yaml b/Documentation/devicetree/bindings/mfd/adi,max77659.yaml > new file mode 100644 > index 000000000000..6bec11607615 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/adi,max77659.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/adi,max77659.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MAX77659 SIMO PMIC from ADI. Drop full stop. > + > +maintainers: > + - Nurettin Bolucu <Nurettin.Bolucu@xxxxxxxxxx> > + - Zeynep Arslanbenzer <Zeynep.Arslanbenzer@xxxxxxxxxx> > + > +description: | > + MAX77659 is an PMIC providing battery charging and power > + supply solutions for low-power applications. > + > + For device-tree bindings of other sub-modules (regulator, power supply > + refer to the binding documents under the respective > + sub-system directories. Drop this part, not really relevant. > + > +properties: > + compatible: > + const: adi,max77659 > + > + reg: > + description: > + I2C device address. Drop description. > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + charger: > + $ref: ../power/supply/adi,max77659-charger.yaml Full path, so /schemas/ There is no such file so you did not test the patch. > + > + regulator: > + $ref: ../regulator/adi,max77659-regulator.yaml Ditto There is no such file so you did not test the patch. > + > +required: > + - compatible > + - reg > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + pmic@40 { > + compatible = "adi,max77659"; > + reg = <0x40>; > + interrupt-parent = <&gpio>; > + #interrupt-cells = <2>; > + interrupts = <16 IRQ_TYPE_EDGE_FALLING>; > + regulator { > + compatible = "adi,max77659-regulator"; > + regulator-boot-on; > + regulator-always-on; > + }; > + charger { > + compatible = "adi,max77659-charger"; > + adi,fast-charge-timer = <5>; That's not DT coding style... > + adi,fast-charge-microamp = <15000>; > + adi,topoff-timer = <30>; Same problem. > Best regards, Krzysztof
