On 2022/12/16 19:03, Krzysztof Kozlowski wrote: > On 16/12/2022 08:06, Yanhong Wang wrote: >> Some boards(such as StarFive VisionFive v2) require more than one value >> which defined by resets property, so the original definition can not >> meet the requirements. In order to adapt to different requirements, >> adjust the maxitems number from 1 to 3.. >> >> Signed-off-by: Yanhong Wang <yanhong.wang@xxxxxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/net/snps,dwmac.yaml | 15 +++++++++++---- >> 1 file changed, 11 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> index e26c3e76ebb7..7870228b4cd3 100644 >> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml >> @@ -133,12 +133,19 @@ properties: >> - ptp_ref >> >> resets: >> - maxItems: 1 >> - description: >> - MAC Reset signal. >> + minItems: 1 >> + maxItems: 3 >> + additionalItems: true >> + items: >> + - description: MAC Reset signal >> >> reset-names: >> - const: stmmaceth >> + minItems: 1 >> + maxItems: 3 >> + additionalItems: true >> + contains: >> + enum: >> + - stmmaceth > > No, this is highly unspecific and you know affect all the schemas using > snps,dwmac.yaml. Both lists must be specific - for your device and for > others. > I have tried to define the resets in "starfive,jh71x0-dwmac.yaml", but it can not over-write the maxItems limit in "snps,dwmac.yaml",therefore, it will report error "reset-names: ['stmmaceth', 'ahb'] is too long" running "make dt_binding_check". Do you have any suggestions to deal with this situation? > Best regards, > Krzysztof >
