Hi Benjamin, On Mon, Dec 19, 2022 at 12:56 PM Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxxxxx> wrote: > > This series implement AV1 stateless decoder for RK3588 SoC. > The harware support 8 and 10 bits bitstreams up to 7680x4320. > AV1 feature like film grain or scaling are done by the postprocessor. > The driver can produce NV12_4L4 and NV12 pixel formats. > A native 10bits NV12_4L4 format is possible but need more investigation > to be completly documented and enabled. > > It is based on Daniel's "[RFC,v3] media: Add AV1 uAPI" [1] patches and > Sebastian's device-tree patches for RK3588. > I thought the AV1 decoder in RK3588 was really a separate hardware from the Hantro G1/G2. Shouldn't this need a new driver for this new hardware? Thanks! Ezequiel > The full branch can be found here: > https://gitlab.collabora.com/linux/for-upstream/-/commits/rk3588_av1_decoder_v1 > > Fluster score is: 151/239 while testing AV1-TEST-VECTORS with GStreamer-AV1-V4L2SL-Gst1.0. > The failing tests are: > - 10bits bitstream because 10bits output formats aren't yet implemented. > - the 2 tests with 2 spatial layers: few errors in luma/chroma values > - tests with resolution < hardware limit (64x64) > > Benjamin > > Benjamin Gaignard (9): > dt-bindings: media: rockchip-vpu: Add rk3588 vpu compatible > media: verisilicon: Add AV1 decoder mode and controls > media: verisilicon: Save bit depth for AV1 decoder > media: verisilicon: Check AV1 bitstreams bit depth > media: verisilicon: Compute motion vectors size for AV1 frames > media: verisilicon: Add AV1 entropy helpers > media: verisilicon: Add Rockchip AV1 decoder > media: verisilicon: Add film grain feature to AV1 driver > media: verisilicon: Enable AV1 decoder on rk3588 > > .../bindings/media/rockchip-vpu.yaml | 1 + > drivers/media/platform/verisilicon/Makefile | 3 + > drivers/media/platform/verisilicon/hantro.h | 5 + > .../media/platform/verisilicon/hantro_drv.c | 54 + > .../media/platform/verisilicon/hantro_hw.h | 102 + > .../platform/verisilicon/hantro_postproc.c | 3 + > .../media/platform/verisilicon/hantro_v4l2.c | 5 + > .../verisilicon/rockchip_av1_entropymode.c | 4536 +++++++++++++++++ > .../verisilicon/rockchip_av1_entropymode.h | 272 + > .../verisilicon/rockchip_av1_filmgrain.c | 401 ++ > .../verisilicon/rockchip_av1_filmgrain.h | 36 + > .../verisilicon/rockchip_vpu981_hw_av1_dec.c | 2280 +++++++++ > .../verisilicon/rockchip_vpu981_regs.h | 477 ++ > .../platform/verisilicon/rockchip_vpu_hw.c | 116 + > 14 files changed, 8291 insertions(+) > create mode 100644 drivers/media/platform/verisilicon/rockchip_av1_entropymode.c > create mode 100644 drivers/media/platform/verisilicon/rockchip_av1_entropymode.h > create mode 100644 drivers/media/platform/verisilicon/rockchip_av1_filmgrain.c > create mode 100644 drivers/media/platform/verisilicon/rockchip_av1_filmgrain.h > create mode 100644 drivers/media/platform/verisilicon/rockchip_vpu981_hw_av1_dec.c > create mode 100644 drivers/media/platform/verisilicon/rockchip_vpu981_regs.h > > -- > 2.34.1 >
