On Mon, Nov 03, 2014 at 03:40:35PM +0100, Javier Martinez Canillas wrote: > Hello Mark, > > This is the fourth version of the series that adds operating modes > support for the regulators in the max77802 PMIC. This version uses No, it's not. This is a a patch series doing a whole bunch of different things, there's at least bug fixes to existing drivers, new features and also this new driver in what I've glanced at so far. These things shouldn't just be being thrown together into a single patch series, and the patch series shouldn't then be described as just being what is in the end a minor part of the collection. Doing this makes things more manageable from the review side, avoids pointless dependencies and avoids setting off alarm bells. My first thought when seeing this was "how can a regulator driver be so complex as to need 14 patches, there must be something seriously wrong here". The whole thing about making sure that what you're doing makes sense beyond just giving the correct test results also applies to sending the patches - think if what's being said to the people reviewing the patches is sensible.
Attachment:
signature.asc
Description: Digital signature
