On 19/12/2022 10:42, Xingyu Wu wrote: > Add bindings to describe the watchdog for the StarFive JH7110 SoC. > > Signed-off-by: Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx> > --- > .../watchdog/starfive,jh7110-wdt.yaml | 64 +++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/starfive,jh7110-wdt.yaml > > diff --git a/Documentation/devicetree/bindings/watchdog/starfive,jh7110-wdt.yaml b/Documentation/devicetree/bindings/watchdog/starfive,jh7110-wdt.yaml > new file mode 100644 > index 000000000000..a7bfe0751928 > --- /dev/null > +++ b/Documentation/devicetree/bindings/watchdog/starfive,jh7110-wdt.yaml > @@ -0,0 +1,64 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/watchdog/starfive,jh7110-wdt.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: StarFive Watchdog > + > +maintainers: > + - Samin Guo <samin.guo@xxxxxxxxxxxxxxxx> > + - Xingyu Wu <xingyu.wu@xxxxxxxxxxxxxxxx> > + You miss watchdog.yaml. I asked to drop the quotes (so the " character), not the $ref. Please keep the $ref: watchdog.yaml and use unevaluatedProperties at the end (instead of additionalProperties). Best regards, Krzysztof