Hi, This is the forth version of this driver. V3 could be found here [1]. Changes since v3. - Addressed review comments from Hartmut Knaack and Mark Rutland: Better description of 'reg' property. Add # to address-cells and size-cells DT document. Dropped interrupt-names property, it was not actually used by driver. DT header file, which contain channels names definitions, is part of documentation patch now. Clarified 'qcom,decimation' property. Hopefully it make sense now. Make more explicit that all reference channels configuration nodes have to be defined in DT. - Promote dev_dbg to dev_err in error paths. Stan, I hope you are ok with this :-) - Use 32 bit calculations in calibration routine. - Read ADC result with one regmap call. - Show status and state registers if ADC conversin fails. Errors should not normally happen, so I will like to see content of this registers in such cases. - Use new struct iio_info::of_xlate for channel number translation. - Removed device wakeup initialization code, which didn't make sense to me for such kind of device. Patches depend on "iio: inkern: Add of_xlate function to struct iio_info" patch, which is included in IIO testing branch [2]. [1] http://comments.gmane.org/gmane.linux.ports.arm.msm/9741 [2] http://git.kernel.org/cgit/linux/kernel/git/jic23/iio.git/log/?h=testing Stanimir Varbanov (2): DT: iio: vadc: document dt binding iio: vadc: Qualcomm SPMI PMIC voltage ADC driver .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 129 +++ drivers/iio/adc/Kconfig | 14 + drivers/iio/adc/Makefile | 1 + drivers/iio/adc/qcom-spmi-vadc.c | 1015 ++++++++++++++++++++ include/dt-bindings/iio/qcom,spmi-vadc.h | 119 +++ 5 files changed, 1278 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/qcom,spmi-vadc.txt create mode 100644 drivers/iio/adc/qcom-spmi-vadc.c create mode 100644 include/dt-bindings/iio/qcom,spmi-vadc.h -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
