Re: [PATCH 1/4] dt-bindings: arm: Split i.MX8M Mini Toradex Verdin based boards

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/16/22 12:56, Francesco Dolcini wrote:
On Fri, Dec 16, 2022 at 12:43:35PM +0100, Marek Vasut wrote:
On 12/16/22 08:18, Francesco Dolcini wrote:
Hello Marek

Hi,

On Fri, Dec 16, 2022 at 12:21:34AM +0100, Marek Vasut wrote:
The Toradex Verdin based boards have compatible string in the form:
"vendor,custom-board", "toradex,som", "fsl,soc"
Split the binding entry so this triplet can be matched on.

Signed-off-by: Marek Vasut <marex@xxxxxxx>
---
Cc: Fabio Estevam <festevam@xxxxxxx>
Cc: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
Cc: Marcel Ziswiler <marcel.ziswiler@xxxxxxxxxxx>
Cc: Peng Fan <peng.fan@xxxxxxx>
Cc: Rob Herring <robh+dt@xxxxxxxxxx>
Cc: Shawn Guo <shawnguo@xxxxxxxxxx>
Cc: NXP Linux Team <linux-imx@xxxxxxx>
Cc: devicetree@xxxxxxxxxxxxxxx
To: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
---
   Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++-
   1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 05b5276a0e14c..8dda0e25b99e4 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -830,7 +830,6 @@ properties:
                 - innocomm,wb15-evk         # i.MX8MM Innocomm EVK board with WB15 SoM
                 - kontron,imx8mm-sl         # i.MX8MM Kontron SL (N801X) SOM
                 - kontron,imx8mm-osm-s      # i.MX8MM Kontron OSM-S (N802X) SOM
-              - menlo,mx8menlo            # i.MX8MM Menlo board with Verdin SoM
                 - toradex,verdin-imx8mm     # Verdin iMX8M Mini Modules
                 - toradex,verdin-imx8mm-nonwifi  # Verdin iMX8M Mini Modules without Wi-Fi / BT
                 - toradex,verdin-imx8mm-wifi  # Verdin iMX8M Mini Wi-Fi / BT Modules
@@ -838,6 +837,12 @@ properties:
                 - prt,prt8mm                # i.MX8MM Protonic PRT8MM Board
             - const: fsl,imx8mm
+      - description: Verdin iMX8M Mini Module based Boards
I would expect here something like "i.MX8MM Menlo board with Verdin SoM", am I wrong?

Partly wrong, look at 4/4 patch in this series for how this would grow once
more boards based on the Verdin SoM would be added. The first -const: would
turn into enum, the remaining two -const: would remain (different carrier
board, same SoM, same SoC).

Shouldn't you than add it to existing `Toradex Boards with Verdin iMX8M Mini Modules`
one as a new entry to the existing enum?  Maybe the current name is not
ideal if we do something like that and should become `Boards using
Toradex Verdin iMX8M Mini Modules` if we add menlo to it ?

I should, I missed that, will be fixed in V2, thanks.



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux