Hi Chris, looks good to me, just very minor nitpicks: On Wed, Dec 14, 2022 at 7:06 PM Chris Morgan <macroalpha82@xxxxxxxxx> wrote: > > From: Chris Morgan <macromorgan@xxxxxxxxxxx> > > Support Magnachip D53E6EA8966 based panels such as the Samsung > AMS495QA01 panel as found on the Anbernic RG503. Note this driver > supports only the AMS495QA01 today which receives video signals via DSI, > however it receives commands via 3-wire SPI. using DBI. > > Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx> > Signed-off-by: Maya Matuszczyk <maccraft123mc@xxxxxxxxx> Is your Kconfig snippet missing: depends on BACKLIGHT_CLASS_DEVICE ? > +#include <linux/of_device.h> > +#include <linux/of_graph.h> Not needed anymore, right? With these fixed: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij