Re: [PATCH 1/7] arm64: dts: tqma8mpql: Fix temperature sensor compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alexander,

On 22-12-14, Alexander Stein wrote:
> Use the correct compatible 'nxp,se97b' as it is an SE97BTP chip.
> While at it, fix the node name according to device tree spec
> recommendations. The EEPROM is a separate node anyway.

Just FTR: sometimes other components like bootloaders use the node names
as well, therefore changing node names should be done with caution. For
this series it is okay I think.

> 
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>

The whole series lgtm, feel free to add my.

Reviewed-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>

> ---
>  arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 5 ++---
>  arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql.dtsi         | 5 ++---
>  2 files changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> index a3340814099aa..f7f657b007a18 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts
> @@ -516,9 +516,8 @@ tlv320aic3x04: audio-codec@18 {
>  		ldoin-supply = <&reg_vcc_3v3>;
>  	};
>  
> -	/* NXP SE97BTP with temperature sensor + eeprom */
> -	se97_1c: temperature-sensor-eeprom@1c {
> -		compatible = "nxp,se97", "jedec,jc-42.4-temp";
> +	se97_1c: temperature-sensor@1c {
> +		compatible = "nxp,se97b", "jedec,jc-42.4-temp";
>  		reg = <0x1c>;
>  	};
>  
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql.dtsi
> index 7bd680a926ce7..ebc29a950ba9a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql.dtsi
> @@ -63,9 +63,8 @@ &i2c1 {
>  	sda-gpios = <&gpio5 15 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
>  	status = "okay";
>  
> -	/* NXP SE97BTP with temperature sensor + eeprom */
> -	se97: temperature-sensor-eeprom@1b {
> -		compatible = "nxp,se97", "jedec,jc-42.4-temp";
> +	se97: temperature-sensor@1b {
> +		compatible = "nxp,se97b", "jedec,jc-42.4-temp";
>  		reg = <0x1b>;
>  	};
>  
> -- 
> 2.34.1
> 
> 
> 



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux