Re: [PATCH] dt-bindings: arm: qcom: add board-id/msm-id for MSM8956, SDM636 and SM4250

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2022-12-14 16:06:05, Krzysztof Kozlowski wrote:
> Allow qcom,board-id and qcom,msm-id leagcy properties on these older
> platforms: MSM8956, SDM636 and SM4250.  Also mention more OnePlus
> devices using modified qcom,board-id field.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>

> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index d45e2129fce3..cfb7f5caf606 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -925,15 +925,18 @@ allOf:
>                - qcom,apq8026
>                - qcom,apq8094
>                - qcom,apq8096
> +              - qcom,msm8956

I am certain this (and msm8976) were added in [1] but it somehow got
lost when that was merged as 05c0c38dc752 ("dt-bindings: arm: qcom:
Document msm8956 and msm8976 SoC and devices")?

Should we also add qcom,msm8976 or only when a user for that board is
added?

[1]: https://lore.kernel.org/linux-arm-msm/20221111120156.48040-9-angelogioacchino.delregno@xxxxxxxxxxxxx/

>                - qcom,msm8992
>                - qcom,msm8994
>                - qcom,msm8996
>                - qcom,msm8998
>                - qcom,sdm630
>                - qcom,sdm632
> +              - qcom,sdm636
>                - qcom,sdm845
>                - qcom,sdx55
>                - qcom,sdx65
> +              - qcom,sm4250

qcom,sm6115 could be added as well unless you rather leave that to the
person(s) adding the board compatible later on.

- Marijn

>                - qcom,sm6125
>                - qcom,sm6350
>                - qcom,sm7225
> @@ -957,6 +960,8 @@ allOf:
>                - oneplus,dumpling
>                - oneplus,enchilada
>                - oneplus,fajita
> +              - oneplus,oneplus3
> +              - oneplus,oneplus3t
>      then:
>        properties:
>          qcom,board-id:
> -- 
> 2.34.1
> 



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux