On 14/12/2022 05:41, Sriranjani P wrote: > > >> -----Original Message----- >> From: Rob Herring [mailto:robh@xxxxxxxxxx] >> Sent: 10 December 2022 02:40 >> To: Sriranjani P <sriranjani.p@xxxxxxxxxxx> >> Cc: krzysztof.kozlowski+dt@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; >> alim.akhtar@xxxxxxxxxxx; pankaj.dubey@xxxxxxxxxxx; >> ravi.patel@xxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-arm- >> kernel@xxxxxxxxxxxxxxxxxxx; linux-samsung-soc@xxxxxxxxxxxxxxx >> Subject: Re: [PATCH v2 1/4] dt-bindings: soc: samsung: exynos-sysreg: add >> dedicated SYSREG compatibles to Exynos850 >> >> On Wed, Dec 07, 2022 at 04:20:29PM +0530, Sriranjani P wrote: >>> Exynos850 has two different SYSREGs, hence add dedicated compatibles >>> for them and deprecate usage of generic Exynos850 compatible alone. >>> >>> Signed-off-by: Sriranjani P <sriranjani.p@xxxxxxxxxxx> >>> --- >>> .../soc/samsung/samsung,exynos-sysreg.yaml | 15 ++++++++++++--- >>> 1 file changed, 12 insertions(+), 3 deletions(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysreg. >>> yaml >>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysreg. >>> yaml index 4954790eda6c..a37452965100 100644 >>> --- >>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos- >> sysreg. >>> yaml >>> +++ >> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sys >>> +++ reg.yaml >>> @@ -17,7 +17,6 @@ properties: >>> - samsung,exynos3-sysreg >>> - samsung,exynos4-sysreg >>> - samsung,exynos5-sysreg >>> - - samsung,exynos850-sysreg >>> - samsung,exynosautov9-sysreg >>> - tesla,fsd-cam-sysreg >>> - tesla,fsd-fsys0-sysreg @@ -33,9 +32,17 @@ properties: >>> - const: samsung,exynos5433-sysreg >>> - const: syscon >>> - items: >>> - - const: samsung,exynos5433-sysreg >>> + - enum: >>> + - const: samsung,exynos5433-sysreg >> >> This says the compatible entry is "const: samsung,exynos5433-sysreg". >> >> That should be a schema warning. You did test this, right? > Thanks for pointing it out, somehow dtbs check not showed any error. Will > fix it in the next version. To test binding please run dt_binding_check instead. Best regards, Krzysztof
