On 13/12/2022 20:20, Konrad Dybcio wrote: > >> >>> then: >>> properties: >>> clocks: >>> @@ -105,10 +116,12 @@ allOf: >>> - if: >>> properties: >>> compatible: >>> - contains: >>> - enum: >>> - - qcom,msm8916-cci >>> - - qcom,msm8996-cci >>> + oneOf: >>> + - contains: >>> + enum: >>> + - qcom,msm8916-cci >>> + >>> + - const: qcom,msm8996-cci >> >> The same comment. > e.g. the 845 example contains 8996 but does not fall in this category, > reverting this change causes errors. Ah, I see, indeed. Looks reasonable: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof